[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397827#comment-17397827
]
Zach Chen commented on LUCENE-10002:
------------------------------------
Hi [~jpountz] [~gsmiller], I have created a PR for this to deprecate the
collector API in favor of the collector manager API, as well as some initial
refactoring to some tests and the parts in DrillSideways that use
TopScoreDocCollector & TopFieldCollector to use the latter API. I plan to
submit more PRs afterward for other areas in the codebase.
Please note that I did first try to remove the collector API entirely, but that
ended up resulting in way too many changes than I'm comfortable with in a
single PR, and I also feel this API is such a commonly used one that users may
prefer a more gradual deprecation / transition period. Hence I reverted my
previous effort and adopted a phased approach.
> Remove IndexSearcher#search(Query,Collector) in favor of
> IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10002
> URL: https://issues.apache.org/jira/browse/LUCENE-10002
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but
> that it would always search on the caller thread when calling
> {{IndexSearcher#search(Query,Collector)}}.
> Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to
> {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory
> methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to
> return a {{CollectorManager}} instead of a {{Collector}}?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
