uschindler commented on a change in pull request #203:
URL: https://github.com/apache/lucene/pull/203#discussion_r663352625



##########
File path: 
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90CompoundFormat.java
##########
@@ -106,8 +107,13 @@ private void writeCompoundFile(
     // write number of files
     entries.writeVInt(si.files().size());
     for (String file : si.files()) {
+      // align file start offset
+      long startOffset = data.getFilePointer(), alignedStartOffset = 
alignOffset(startOffset);

Review comment:
       We could mayb add a method to IndexOutput to forward the file pointer to 
the next boundary like implemented here.
   This would allow to also do the same for docvalues random access slices (the 
one I am working towards).
   
   Maybe `long IndexOutput#alignFilePointer()`, returning the new aligned file 
pointer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to