[ 
https://issues.apache.org/jira/browse/LUCENE-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373102#comment-17373102
 ] 

Mike Drob commented on LUCENE-10017:
------------------------------------

It looks like the actual index versions in the footer don't let us 
differentiate between arbitrary 7x and an 8x, there's a [big 
jump|https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java#L123]
 from 7.4 to 8.6 in the file metadata.

One option is to just explicitly check for IFTOE before adding a suppressed 
corrupted index exception, which I'll put up as a PR. Maybe there's a better 
heuristic to use instead.

> Do not check footers on Lucene7x segments when throwing IndexFormatTooOld
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-10017
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10017
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: main (9.0)
>            Reporter: Mike Drob
>            Priority: Major
>
> Ran into this while investigating how to improve the logging situation in 
> SOLR-15516
> When we throw an IndexFormatTooOldException when attempting to read a 
> segment, we will read still attempt to read the footer since it is newer than 
> 7x (which AFAIUI was the oldest version to support these footers?)
> We should update that to only check footers for versions newer than 8x, 
> otherwise we create a needless additional exception.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to