rmuir commented on a change in pull request #191:
URL: https://github.com/apache/lucene/pull/191#discussion_r658678204
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -162,8 +164,14 @@ private void count(String field, List<MatchingDocs>
matchingDocs) throws IOExcep
if (limit > 0) {
totCount++;
}
+ Set<Long> uniqueLongValues =
+ new HashSet<>(); // count each repeated long value in a field as
the same
Review comment:
the values are sorted though. so isn't it enough to just use a check
such as `if (value != previousValue)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
