[ 
https://issues.apache.org/jira/browse/LUCENE-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368849#comment-17368849
 ] 

ASF subversion and git services commented on LUCENE-9962:
---------------------------------------------------------

Commit 22c1c78bb395c77de19d6d9e9677b6efa872c11f in lucene-solr's branch 
refs/heads/branch_8x from Greg Miller
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=22c1c78 ]

LUCENE-9962, LUCENE-9944, LUCENE-9988: DrillSideways improvement backports 
(#2506)

* LUCENE-9962: Allow DrillSideways sub-classes to provide their own "drill 
down" facet counting implementation (or null)
* LUCENE-9944: Allow DrillSideways users to pass a CollectorManager without 
requiring an ExecutorService (and concurrent DrillSideways approach)
* LUCENE-9988: Fix DrillSideways bug discovered in randomized testing

> DrillSideways users should be able to opt-out of "drill down" facet collecting
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-9962
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9962
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: main (9.0)
>            Reporter: Greg Miller
>            Priority: Minor
>             Fix For: main (9.0)
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The {{DrillSideways}} search methods will _always_ populate a 
> {{FacetsCollector}} for the "drill down" dimensions in addition to the "drill 
> sideways" dimensions. For most cases, this makes sense, but it would be nice 
> if users had a way to opt-out of this collection. It's possible a user may 
> not care to do any faceting on "drill down" dims, or may have custom needs 
> for facet collecting on the "drill downs." For the latter case, the user 
> might want to provide a {{Collector}}/{{CollectorManager}} that does facet 
> collecting with some custom logic (e.g., behind a 
> {{MultiCollector}}/{{MultiCollectorManager}}), in which case the population 
> of an additional {{FacetsCollector}} in {{DrillSideways}} is wasteful.
> The {{DrillSidewaysScorer}} already supports a {{null}} 
> {{drillDownCollector}} gracefully, so this change should mostly just involve 
> creating a {{protected}} method in {{DrillSideways}} for the purpose of 
> creating a "drill down" {{FacetsCollector}} that users can override by 
> providing {{null}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to