jpountz commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r652536636
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java
##########
@@ -310,6 +310,9 @@ public final int hashCode() {
*/
public abstract Fields getTermVectors(int docID) throws IOException;
Review comment:
Let's make this one final, deprecated and delegate to the below method?
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java
##########
@@ -310,6 +310,9 @@ public final int hashCode() {
*/
public abstract Fields getTermVectors(int docID) throws IOException;
+ /** Get TermVectors from this index. */
+ public abstract TermVectors getTermVectorsNonThreadLocal();
Review comment:
Let's rename to `getTermVectorsReader`, the same name it has on
`CodecReader`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
