[ https://issues.apache.org/jira/browse/LUCENE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362936#comment-17362936 ]
Greg Miller commented on LUCENE-10001: -------------------------------------- [~jpountz] thanks for the feedback! The specific use-case I have in mind is early-terminating facet collection. Imagine the user has a "primary" collector that's collecting top-n hits and is also collecting into a {{FacetsCollector}}. Also imagine the primary collector has some early-termination logic where it's able to signal that it's finished collecting, after a certain number of hits have been seen or time has passed, etc. It could be desirable to also early-terminate the {{FacetsCollector}} collection early as well. The facet counting then becomes incomplete, just like the primary collector, but allows the user bound the collection time in some way (hits seen, time, etc.). Essentially the {{FacetsCollector}} isn't able to know on its own when it has seen enough hits to terminate, and is relying on another collector to make that determination. This use-case is a real one I'm familiar with, but it may not be general enough to support here? Would be curious to hear what you think. Thanks again! > Make CollectionTerminatedException handling in MultiCollector configurable > -------------------------------------------------------------------------- > > Key: LUCENE-10001 > URL: https://issues.apache.org/jira/browse/LUCENE-10001 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Affects Versions: main (9.0) > Reporter: Greg Miller > Assignee: Greg Miller > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > In LUCENE-6772, {{MultiCollector}} was modified to continue collecting > against other leaf collectors that had not thrown a > {{CollectionTerminatedException}} in cases where another one does. It would > be nice if this behavior could be configurable. Some use-cases might actually > want to early terminate all leaf collectors as soon as one signals early > termination. > We could add a configurable option to the {{MultiCollector#wrap}} factory > methods that allows users to specify the behavior they want. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org