zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r642641460
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -450,6 +479,14 @@ public void setChecksumsOnly(boolean v) {
private boolean checksumsOnly;
+ /** Set threadCount used for parallelizing index integrity checking. */
+ public void setThreadCount(int tc) {
+ threadCount = tc;
+ }
+
+ // capped threadCount at 4
+ private int threadCount =
Math.min(Runtime.getRuntime().availableProcessors(), 4);
Review comment:
Ah I thought we would like to cap it to 4 (or 8) per earlier comment.
But I think in latest changes I actually removed away the usage of this
default, as when the user does not pass in `-threadCount`, the execution will
use 0 for `threadCount` and fallback to sequential check. Should we give user
this flexibility to not use concurrent check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
