[ 
https://issues.apache.org/jira/browse/LUCENE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Miller updated LUCENE-9971:
--------------------------------
    Fix Version/s: main (9.0)
       Resolution: Fixed
           Status: Resolved  (was: Patch Available)

> Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-9971
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9971
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alexander L
>            Priority: Minor
>             Fix For: main (9.0)
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Unlike other org.apache.lucene.facet.Facet interface implementations, 
> SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts 
> [throw an exception in case of unseen dimension in the getTopChildren() 
> method 
> |https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java#L99]
>  
> It is inconsistent with [Facet interface 
> documentation|https://github.com/apache/lucene/blob/main/lucene/facet/src/java/org/apache/lucene/facet/Facets.java#L33]
>  and not pleasant to deal with: in our case requested dimensions can be 
> manually specified by the user, so we should always catch that and check the 
> exception message to be sure of the exact cause.
> During the PR review, it was also decided to make similar changes for 
> Taxonomy implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to