sqshq commented on a change in pull request #149:
URL: https://github.com/apache/lucene/pull/149#discussion_r642119150
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -157,6 +157,11 @@ public DimConfig getDimConfig(String dimName) {
return dimConfig;
}
+ /** Returns false if the dimension was never configured. */
Review comment:
Sounds good, added these details to the javadoc:
https://github.com/apache/lucene/pull/149/commits/074939baa1fca6be46eb33542c7aa76cf4cddafa.
We can also rename the method to `isDimCustomized`, if you think it looks less
ambiguous. Let me know!
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java
##########
@@ -16,15 +16,17 @@
*/
package org.apache.lucene.facet.taxonomy;
+import static org.apache.lucene.facet.FacetsConfig.*;
Review comment:
Sure, good to know!
https://github.com/apache/lucene/pull/149/commits/074939baa1fca6be46eb33542c7aa76cf4cddafa
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java
##########
@@ -111,14 +113,25 @@ public boolean siblingsLoaded() {
}
/**
- * Throws {@code IllegalArgumentException} if the dimension is not
recognized. Otherwise, returns
- * the {@link DimConfig} for this dimension.
+ * Verifies and returns {@link DimConfig} the given dimension name.
Review comment:
Fixed that, thanks!
https://github.com/apache/lucene/pull/149/commits/074939baa1fca6be46eb33542c7aa76cf4cddafa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
