zacharymorn commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r639417993
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -2795,12 +2972,14 @@ public Relation compare(byte[] minPackedValue, byte[]
maxPackedValue) {
* @lucene.experimental
*/
public static Status.DocValuesStatus testDocValues(
- CodecReader reader, PrintStream infoStream, boolean failFast) throws
IOException {
Review comment:
Yes. If it's invoked via `CheckIndex#checkIndex`, and `failFast = true`,
error from segment part check will be stored inside each `Status` object, and
then after `join` `CheckIndexException` will be thrown via these code
```
if (segInfoStat.liveDocStatus.error != null) {
throw new CheckIndexException(segmentId, "", "Live docs test failed",
segInfoStat.liveDocStatus.error);
}
```
which will be caught in the outside `catch` block and rethrown via
```
if (failFast) {
throw IOUtils.rethrowAlways(t);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
