dweiss commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r638657529



##########
File path: lucene/test-framework/src/java/org/apache/lucene/util/TestUtil.java
##########
@@ -321,6 +321,7 @@ public static void syncConcurrentMerges(MergeScheduler ms) {
       checker.setDoSlowChecks(doSlowChecks);
       checker.setFailFast(failFast);
       checker.setInfoStream(new PrintStream(output, false, IOUtils.UTF_8), 
false);
+      checker.setThreadCount(RandomNumbers.randomIntBetween(new Random(), 1, 
5));

Review comment:
       You should use randomized testing's context random, otherwise tests are 
not reproducible. Use this static method from RandomizedTest: 
https://github.com/randomizedtesting/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/RandomizedTest.java#L161.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to