gautamworah96 commented on a change in pull request #138:
URL: https://github.com/apache/lucene/pull/138#discussion_r637197151
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillDownQuery.java
##########
@@ -53,6 +53,8 @@ public static Term term(String field, String dim, String...
path) {
private final Query baseQuery;
private final List<BooleanQuery.Builder> dimQueries = new ArrayList<>();
private final Map<String, Integer> drillDownDims = new LinkedHashMap<>();
+ private boolean isDimQueriesDirty = true;
Review comment:
In general I could not imagine a real world case where a user would want
to add drill down subqueries in between calls to getDrillDownQueries. Usually,
we would expect them to add subqueries in one go as soon as they are done with
processing some external request. This also introduces some complexity in a few
places. But it is still worth trying out :)
The next commit has implemented the tracking *dirty status* per subquery
approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
