gsmiller commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r632722791
########## File path: lucene/facet/src/java/org/apache/lucene/facet/StringDocValuesReaderState.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet; + +import java.io.IOException; +import java.util.List; +import org.apache.lucene.index.DocValues; +import org.apache.lucene.index.IndexReader; +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.index.OrdinalMap; +import org.apache.lucene.index.SortedSetDocValues; +import org.apache.lucene.util.packed.PackedInts; + +/** + * Stores an {@link OrdinalMap} created for a specific {@link IndexReader} ({@code reader}) + {@code + * field}. Enables re-use of the {@code ordinalMap} once created since creation is costly. + * + * <p>Note: It's important that callers confirm the ordinal map is still valid for their cases. + * Specifically, callers should confirm that the reader used to create the map ({@code reader}) + * matches their use-case. + */ +class StringDocValuesReaderState { Review comment: Ah, yes-- it absolutely should along with its ctor. Good catch! I've got my IDE setup to generate all new classes as package-private by default so I have to have a good reason to make something public. This one slipped through the cracks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
