gsmiller opened a new pull request #131: URL: https://github.com/apache/lucene/pull/131
# Description `LongValueFacetCounts` may produce inaccurate counts for `FacetResult#value` in cases where docs are multi-valued. This fixes the bug. Note that I'm proposing this change be included in the 8x branch, so I've also included a separate pull request in the old repo: https://github.com/apache/lucene-solr/pull/2491 # Solution Modify `LongValueFacetCounts` to only count each new document it sees once, instead of once-per-value. # Tests Modified existing test cases in `TestLongValueFacetCounts` to reflect the correct behavior and ensured they pass. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
