[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338091#comment-17338091
]
Robert Muir commented on LUCENE-9948:
-------------------------------------
For 9.0, i wouldnt add back compat at all or deprecations. I think just remove
the parameter. If you want you can add a note to MIGRATE.txt that users just
don't need to supply anything to this boolean. As far as the user goes, it is
easy to adapt code for this change as they simply supply one less parameter,
and let's keep main branch clean of cruft and move forwards
> Automatically detect multi- vs. single-valued cases in LongValueFacetCounts
> ---------------------------------------------------------------------------
>
> Key: LUCENE-9948
> URL: https://issues.apache.org/jira/browse/LUCENE-9948
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: main (9.0)
> Reporter: Greg Miller
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The public API in {{LongValueFacetCounts}} currently requires the user to
> specify whether-or-not a field being counted should be single- or
> multi-valued (i.e., is it {{NumericDocValues}} or
> {{SortedNumericDocValues}}). Since we can detect this automatically, it seems
> unnecessary to ask users to specify. Let's consider updating the
> implementation to auto-detect these cases and deprecate the ctors that allow
> explicit specification.
> This is a spin-off issue from LUCENE-9946.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]