uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-830785124


   > It shouldn't be included by default in test runs though (there is a test 
file name pattern?)
   
   Although this was not the problem here: We have no filename pattern! It 
looks like Gradle figures tests out automatically. But this did not work 
anymore as soon as you enable the Java Module system. Because of this in the 
MMapDirectory v2 I had to add the pattern manually. We should maybe always do 
this, because this was my first idea: "WTF? Again the missing pattern? What the 
hell?"
   
   This should IMHO be applied on main branch in both solr and lucene: 
https://github.com/apache/lucene-solr/pull/2176/files#diff-5389a6d358feee1c8ed596fd91b01bcb373afac3570f463c66b825401afcb297R102-R103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to