neoremind commented on a change in pull request #91:
URL: https://github.com/apache/lucene/pull/91#discussion_r623147194
##########
File path:
lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java
##########
@@ -35,63 +37,60 @@
MutablePointsReaderUtils() {}
- /** Sort the given {@link MutablePointValues} based on its packed value then
doc ID. */
+ /**
+ * Sort the given {@link MutablePointValues} based on its packed value, note
that doc ID is not
+ * taken into sorting algorithm, since if they are already in ascending
order, stable sort is able
+ * to maintain the ordering of doc ID.
+ */
Review comment:
Sure, I can check here, well, I search the codebase, the only user is
`BKDWriter`, the others are some testcases (actually I updated
`TestMutablePointsReaderUtils` to ignore doc ID when comparing), could we make
it a must for the input to have doc IDs in ascending order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
