[GitHub] [lucene] mocobeta commented on a change in pull request #115: LUCENE-4198: add format description for term impacts to javadocs

[GitBox]

mocobeta commented on a change in pull request #115:
URL: https://github.com/apache/lucene/pull/115#discussion_r623054572



##########
File path: 
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PostingsFormat.java
##########
@@ -299,7 +306,7 @@
  *       positions. Some payloads and offsets will be separated out into .pos 
file, for performance
  *       reasons.
  *       <ul>
- *         <li>PayFile(.pay): --&gt; Header, &lt;TermPayloads, TermOffsets?&gt;
+ *         <li>PayFile(.pay): --&gt; Header, &lt;TermPayloads?, 
TermOffsets?&gt;

Review comment:
       It is not related to LUCENE-4198 at all... but TermPayloads seems to be 
optional as well as TermOffsets.
   
https://github.com/apache/lucene/blob/a9a3f6529dac48b9e83a03343b5dda3dc492d955/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PostingsWriter.java#L300-L313




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org