cpoerschke commented on a change in pull request #2482:
URL: https://github.com/apache/lucene-solr/pull/2482#discussion_r619351440
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -303,6 +304,10 @@ private MergePolicy buildMergePolicy(SolrResourceLoader
resourceLoader, IndexSch
new Class[] { SolrResourceLoader.class, MergePolicyFactoryArgs.class,
IndexSchema.class },
new Object[] {resourceLoader, mpfArgs, schema });
+ if (mpf instanceof UninvertDocValuesMergePolicyFactory) {
+ log.warn("UninvertDocValuesMergePolicyFactory will be removed in Solr 9
due to changes in Lucene 9.");
+ }
+
Review comment:
```suggestion
```
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -303,6 +304,10 @@ private MergePolicy buildMergePolicy(SolrResourceLoader
resourceLoader, IndexSch
new Class[] { SolrResourceLoader.class, MergePolicyFactoryArgs.class,
IndexSchema.class },
new Object[] {resourceLoader, mpfArgs, schema });
+ if (mpf instanceof UninvertDocValuesMergePolicyFactory) {
Review comment:
Ah, good point! I'd started with the warning here and added the
deprecation as an afterthought but yes it's much cleaner to have only the
regular deprecation logging, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
