rmuir commented on a change in pull request #84:
URL: https://github.com/apache/lucene/pull/84#discussion_r613628276
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/ScandinavianNormalizationFilter.java
##########
@@ -33,14 +34,45 @@
* <p>blåbærsyltetøj == blåbärsyltetöj == blaabaarsyltetoej but not
blabarsyltetoj räksmörgås ==
* ræksmørgås == ræksmörgaos == raeksmoergaas but not raksmorgas
*
+ * <p>You can choose which of the foldings to apply (aa, ao, ae, oe, oo)
through a parameter.
+ *
* @see ScandinavianFoldingFilter
*/
public final class ScandinavianNormalizationFilter extends TokenFilter {
+ /**
+ * Create the filter with default folding rules, backward compatible with
all earlier versions
+ *
+ * @param input the TokenStream
+ */
public ScandinavianNormalizationFilter(TokenStream input) {
super(input);
+ this.foldings = ALL_FOLDINGS;
}
+ /**
+ * Create the filter using custom folding rules.
+ *
+ * @param input the TokenStream
+ * @param foldings a Set of Foldings to apply (i.e. AE, OE, AA, AO, OO)
+ */
+ public ScandinavianNormalizationFilter(TokenStream input, Set<Foldings>
foldings) {
Review comment:
The thin-wrappers is just the existing design/organization of
lucene/analysis. The idea is that a user has to index a language, they look for
their language and use the available tools. When there are a lot of languages
(and the user may not be subject expert on each one), it is a good
simplification from an API perspective: the user wants to index Danish so they
look at the tools in the 'da' package. So please let's avoid any special
language parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
