[
https://issues.apache.org/jira/browse/LUCENE-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319710#comment-17319710
]
Michael Sokolov commented on LUCENE-9798:
-----------------------------------------
[~nitiraj] I pushed your change, but had to revert. Apparently some tests are
failing. I neglected to run them since I thought github was doing that, but I
think it only does formal checks and doesn't actually run unit tests. Are you
able to take a look?
> Fix looping bug when calculating full KNN results in KnnGraphTester
> -------------------------------------------------------------------
>
> Key: LUCENE-9798
> URL: https://issues.apache.org/jira/browse/LUCENE-9798
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Reporter: Nitiraj Rathore
> Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> There is a minor looping bug when generating Full KNN results for comparison
> with HNSW in KnnGraphTester. Basically, the result in [this
> line|https://github.com/apache/lucene-solr/blob/a53e8e722884e5655206292590da67bb71efc34d/lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java#L551]
> should be calculated after the while loop finishes.
> Without this fix, vector files with ~2GB will work fine but if size of files
> are more than that, it may cause incorrect Full KNN results.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
