iverase commented on a change in pull request #41:
URL: https://github.com/apache/lucene/pull/41#discussion_r602312995



##########
File path: lucene/core/src/test/org/apache/lucene/geo/TestCircle2D.java
##########
@@ -179,4 +179,28 @@ public void testRandomTriangles() {
       }
     }
   }
+
+  public void testLineIntersects() {
+    Component2D circle2D;
+    if (random().nextBoolean()) {
+      Circle circle = new Circle(0, 0, 0.3f);
+      circle2D = LatLonGeometry.create(circle);

Review comment:
       (LatLon) circle radius is defined in meters. I think it needs to be 
changed to ~35000 meters that is equivalent to .3 degrees at the equator?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to