uschindler commented on a change in pull request #21:
URL: https://github.com/apache/lucene/pull/21#discussion_r596662973
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -377,32 +375,33 @@ class RenderJavadocTask extends DefaultTask {
// NOTE: explicitly exclude solr/test-framework, or attempting to link to
lucene-test-framework because if we did javadoc would
// attempt to link class refs in in org.apache.lucene, causing broken
links. (either broken links to things like "Directory" if
// lucene-test-framework was first, or broken links to things like
LuceneTestCase if lucene-core was first)
- if (project.path != ':solr:test-framework') { //
- findRenderTasksInDependencies()
- .sort(false, Comparator.comparing { (it.project.name != 'core') as
Boolean }.thenComparing(Comparator.comparing { it.path }))
- .each { otherTask ->
- def otherProject = otherTask.project
- // For relative links we compute the actual relative link between
projects.
- def crossLuceneSolr = (otherProject.docroot != project.docroot)
- if (relativeProjectLinks && !crossLuceneSolr) {
- def pathTo = otherTask.outputDir.toPath().toAbsolutePath()
- def pathFrom = outputDir.toPath().toAbsolutePath()
- def relative =
pathFrom.relativize(pathTo).toString().replace(File.separator, '/')
- opts << ['-link', relative]
- } else {
- // For absolute links, we determine the target URL by assembling
the full URL.
-
allOfflineLinks.put("${luceneDocUrl}/${otherProject.relativeDocPath}/".toString(),
otherTask.outputDir)
+ findRenderTasksInDependencies()
+ .sort(false, Comparator.comparing { (it.project.name != 'core') as
Boolean }.thenComparing(Comparator.comparing { it.path }))
+ .each { otherTask ->
+ def otherProject = otherTask.project
+ // For relative links we compute the actual relative link between
projects.
+ if (relativeProjectLinks) {
+ def pathTo = otherTask.outputDir.toPath().toAbsolutePath()
+ def pathFrom = outputDir.toPath().toAbsolutePath()
+ def relative =
pathFrom.relativize(pathTo).toString().replace(File.separator, '/')
+ opts << ['-link', relative]
+ } else {
+ // For absolute links, we determine the target URL by assembling
the full URL (if base is available).
+ def value = luceneDocUrl.getOrElse(null)
+ if (value) {
Review comment:
great! My code yesterday looked similar!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
