[ 
https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303442#comment-17303442
 ] 

Uwe Schindler edited comment on LUCENE-9849 at 3/17/21, 1:54 PM:
-----------------------------------------------------------------

Maybe do it like that:
- If the global link is set using the website (which is done for release 
builds), use it
- If there's no global link, we should null it out (instead of creating it with 
some absolute filesystem links). When adding the external links, we check if 
the property is set, if not, don't add any links. The changes required here are 
the default if it's not a release build (null) and the if when adding the link 
using the gobal URL.

The javadocs link checker is a different issue: This one should in my opinion 
only run on the Site Javadocs.


was (Author: thetaphi):
Maybe do it like that:
- If the global link is set using the website (which is done for release 
builds), use it
- If there's no global link, we should null it out (instead of creating is with 
some absolute filesystem links). When adding the external links, we check if 
the property is set, if not, don't add any links.

The javadocs link checker is a different issue: This one should in my opinion 
only run on the Site Javadocs.

> Lucene snapshot javadocs are published with local URLs on jenkins
> -----------------------------------------------------------------
>
>                 Key: LUCENE-9849
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9849
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Priority: Major
>         Attachments: image-2021-03-17-08-55-19-726.png, screenshot-1.png
>
>
>  !image-2021-03-17-08-55-19-726.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to