uschindler commented on a change in pull request #18:
URL: https://github.com/apache/lucene/pull/18#discussion_r594200332
##########
File path: gradle/validation/error-prone.gradle
##########
@@ -22,10 +22,12 @@ if (!includeErrorProne) {
allprojects { prj ->
plugins.withType(JavaPlugin) {
- prj.apply plugin: 'net.ltgt.errorprone'
Review comment:
I think the problem is that the errorprone plugin has some
META-INF/service, so as soon as it appears on classpath it is hooked into javac.
So you latest fix seem to work around it (keep the dependency, but remove it
from config, so it is not added to classpath). I did not fully understand you
patch, but this looks fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
