[ 
https://issues.apache.org/jira/browse/LUCENE-9387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298594#comment-17298594
 ] 

Dawid Weiss commented on LUCENE-9387:
-------------------------------------

I really like those reported diagnostics. I wouldn't worry about fuzziness for 
small indexes (where the actual-reported ratio can be off but it still overall 
not that significant) but I'd still like to see them work fairly well for 
larger segments... 

Why is RamEstimator so much off (I think there is a test that compares reported 
vs. "actual" size?).

I will not stand in the way if you wish to remove it but I think memory 
reporting is useful in many situations (debugging, regression control and even 
at runtime for a rough assessment of the remaining releasable heap, without 
flushing the gc -- we do use this last example).

> Remove RAM accounting from LeafReader
> -------------------------------------
>
>                 Key: LUCENE-9387
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9387
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Blocker
>             Fix For: master (9.0)
>
>
> Context for this issue can be found at 
> https://lists.apache.org/thread.html/r06b6a63d8689778bbc2736ec7e4e39bf89ae6973c19f2ec6247690fd%40%3Cdev.lucene.apache.org%3E.
> RAM accounting made sense when readers used lots of memory. E.g. when norms 
> were on heap, we could return memory usage of the norms array and memory 
> estimates would be very close to actual memory usage.
> However nowadays, readers consume very little memory, so RAM accounting has 
> become less valuable. Furthermore providing good estimates has become 
> incredibly complex as we can no longer focus on a couple main contributors to 
> memory usage, but would need to start considering things that we historically 
> ignored, such as field infos, segment infos, NIOFS buffers, etc.
> Let's remove RAM accounting from LeafReader?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to