[
https://issues.apache.org/jira/browse/SOLR-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294873#comment-17294873
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-15155:
------------------------------------------------------
I linked a PR with the change suggestion. Note that this adds a new method to
the Builder's API:
{code:java}
public Builder withInternalClientBuilder(Http2SolrClient.Builder
internalClientBuilder)
{code}
It's optional and backwards compatible.
> Let CloudHttp2SolrClient accept an external Http2SolrClient Builder
> -------------------------------------------------------------------
>
> Key: SOLR-15155
> URL: https://issues.apache.org/jira/browse/SOLR-15155
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{CloudHttp2SolrClient}} doesn't provide much of the options that
> {{Http2SolrClient}} does (timeouts, max connections per hosts, etc).
> Technically it accepts a fully built {{Http2SolrClient}}, however, in such
> case the client becomes "external", which means it won't be closed when the
> CloudClient is closed (one needs to maintain a reference and close explicitly
> after closing CloudClient).
> {{CloudHttp2SolrClient}} will use an empty/default
> {{Http2SolrClient.Builder}} to build it's internal client. I propose we allow
> providing a configured {{Http2SolrClient.Builder}} instead and let the
> {{CloudHttp2SolrClient}} just build from it. This would be optional of
> course, and backwards compatible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
