ctargett commented on pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#issuecomment-789973767


   > Is 
`{solr-javadocs}/core/org/apache/solr/handler/component/SuggestComponent.html` 
the right syntax? Guess this is not jinja syntax but something else...
   
   This is how all the other javadocs links are constructed (see something like 
`implicit-requesthandlers.adoc`) - this one I found because the URL was 
hardcoded and not using an attribute.
   
   The syntax here is an asciidoctor attribute `{solr-javadocs}` followed by 
the path, so not jinja or anything like that. In `_config.yml_template` the 
asciidoctor `{solr-javadocs}` attribute is mapped to `${htmlSolrJavadocs}`, 
which you can see in the changes to `build.gradle` as mapped to the URL with 
more attribute-based substitution inserting the version to the URL path.
   
   In full disclosure I'm not able to fully test the mapping since there is no 
9_0_0 published javadocs yet to redirect to. I'm planning on making sure it 
still works when I backport to branch_8x and it's probably something that we 
should check again for the 9.0 release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to