murblanc commented on pull request #2438: URL: https://github.com/apache/lucene-solr/pull/2438#issuecomment-787489391
> It appears you merged this PR like 7 hours after you filed it without a review? Normally we either wait for an approved code review, or merge in 2 business days, whichever comes first. If you wish to commit without review, it's also best to comment on your intention to do so stating "lazy consensus" (perhaps saying so at the very start). I agree with you @dsmiley in general about letting the PR's some baking time and opportunity for comments, but this is a minor change (applying a well known pattern) to a previous large PR that didn't get much attention even though I left it out 11 days and requested feedback (Mike Drob did have a look and Noble did make a comment, but no real review happened). Initial [PR 2285](https://github.com/apache/lucene-solr/pull/2285), and I used a rebased one later for merge [PR 2364](https://github.com/apache/lucene-solr/pull/2364). If you do have concerns or comments about the change in this PR, please don't hesitate. Having merged it doesn't mean it can't be changed! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
