gerlowskija commented on a change in pull request #2401: URL: https://github.com/apache/lucene-solr/pull/2401#discussion_r582081552
########## File path: solr/solr-ref-guide/src/cluster-node-management.adoc ########## @@ -420,7 +632,29 @@ http://localhost:8983/solr/admin/collections?action=REMOVEROLE&role=overseer&nod Returns the current status of the overseer, performance statistics of various overseer APIs, and the last 10 failures per operation type. -`/admin/collections?action=OVERSEERSTATUS` +[.dynamic-tabs] +-- +[example.tab-pane#v1overseerstatus] +==== +[.tab-label]*V1 API* + +[source,bash] +---- +http://localhost:8983/solr/admin/collections?action=OVERSEERSTATUS + +---- +==== + +[example.tab-pane#v2overseerstatus] +==== +[.tab-label]*V2 API* + +[source,bash] +---- +curl -X GET http://localhost:8983/api/cluster/overseer -H 'Content-Type: application/json' Review comment: [0] GET requests don't need a `Content-type` header afaik. It doesn't do any harm, but might be simpler to leave it off 🤷 ########## File path: solr/solr-ref-guide/src/cluster-node-management.adoc ########## @@ -125,7 +145,37 @@ http://localhost:8983/solr/admin/collections?action=CLUSTERSTATUS Add, edit or delete a cluster-wide property. -`/admin/collections?action=CLUSTERPROP&name=_propertyName_&val=_propertyValue_` +[.dynamic-tabs] +-- +[example.tab-pane#v1clusterprop] +==== +[.tab-label]*V1 API* + +[source,bash] +---- +http://localhost:8983/solr/admin/collections?action=CLUSTERPROP&name=propertyName&val=propertyValue Review comment: [0] I mentioned elsewhere that it'd be nice to have the v1 and v2 examples be functionally equivalent where possible. Not sure if you took that suggestion or not (nbd either way), but if you liked the idea here's another place where it applies. ########## File path: solr/solr-ref-guide/src/cluster-node-management.adoc ########## @@ -169,6 +219,38 @@ http://localhost:8983/solr/admin/collections?action=CLUSTERPROP&name=urlScheme&v It is possible to set cluster-wide default values for certain attributes of a collection, using the `defaults` parameter. *Set/update default values* +[.dynamic-tabs] Review comment: Whoa, I don't know that I've ever seen this API before. You're setting cluster-wide config properties, but it's a different API command from `action=CLUSTERPROP`. Huh. I knew there were a few v2-only APIs, so I guess that's not a huge surprise, but the overlap between this and `action=CLUSTERPROP` is confusing me a bit. I guess maybe just document the v2 API and leave a note about there not being a v1 equivalent? The docs actually looked this way here before, so maybe no changes are needed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
