[
https://issues.apache.org/jira/browse/LUCENE-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289586#comment-17289586
]
Greg Miller commented on LUCENE-9794:
-------------------------------------
{{Patch attached. I think it's ready to go. I've done my best to add
skipBytes() test coverage everywhere except for CompressingStoredFieldsReader.
That one's a bit tricky to test since it's an anonymous implementation of
DataInput, so testing would need to be pretty indirect. I'll keep thinking
about that one but open to other thoughts/suggestions. That class doesn't seem
to have a lot of existing testing, but that's not an excuse to avoid adding new
tests :)}}
> Optimize skipBytes implementation in remaining DataInput subclasses
> -------------------------------------------------------------------
>
> Key: LUCENE-9794
> URL: https://issues.apache.org/jira/browse/LUCENE-9794
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Greg Miller
> Priority: Minor
> Attachments: LUCENE-9794.patch
>
>
> LUCENE-9480 introduced a more efficient method for byte skipping in
> IndexInput and its subclasses, but the rest of the DataInput implementations
> are still delegating to DataInput#skipBytesSlowly.
>
> This issue tracks optimizing the remaining DataInput skipBytes
> implementations. Here's the list remaining:
> * CompressingStoredFieldsReader (contains an anonymous DataInstance impl
> internally)
> * ByteSliceReader
> * ByteBuffersDataInput
> * InputStreamDataInput
> * PagedBytesDataInput
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
