NazerkeBS commented on a change in pull request #2391:
URL: https://github.com/apache/lucene-solr/pull/2391#discussion_r580973494
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java
##########
@@ -84,7 +88,10 @@ public DocCollection(String name, Map<String, Slice> slices,
Map<String, Object>
* @param zkVersion The version of the Collection node in Zookeeper (used
for conditional updates).
*/
public DocCollection(String name, Map<String, Slice> slices, Map<String,
Object> props, DocRouter router, int zkVersion) {
- super(props==null ? props = new HashMap<>() : props);
+ super(props);
+ if (props == null || props.containsKey("baseConfigSet")) {
Review comment:
this was outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
