gerlowskija opened a new pull request #2380: URL: https://github.com/apache/lucene-solr/pull/2380
# Description As originally implemented, SolrCloud's `restore` operation only supported restoring to collections that didn't yet exist. This was primarily done out of a fear of race conditions involving writes to the collection. Since then the support for toggling a per-collection "readonly" property has made restoration to existing collections possible, but unimplemented. # Solution This PR adds a codepath to restore to an existing collection, assuming it is compatible with the stored backup files. (A backup with 2 shards can't be restored to a collection with 3, etc.). If the collection doesn't exist, the restoration process continues to create it as it has done done in the past. # Tests Manual testing, and automated tests added to AbstractIncrementalBackupTest. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
