jward-bw commented on pull request #216: URL: https://github.com/apache/lucene-solr-operator/pull/216#issuecomment-779755262
> Are you using the kustomize version specified in hack/install_dependencies.sh? Yep that was the issue, I had an older version installed. > ... implement the functionality in the prometheusExporter code as well? Done! > Would you mind adding a test for this? Sorry this is my first time writing go code, and I'm not familiar with the testing structure. Where should tests for these changes go? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
