chatman commented on a change in pull request #2318: URL: https://github.com/apache/lucene-solr/pull/2318#discussion_r575485111
########## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ########## @@ -256,6 +280,23 @@ public void call(ClusterState clusterState, ZkNodeProps message, @SuppressWarnin shardRequestTracker.processResponses(results, shardHandler, false, null, Collections.emptySet()); @SuppressWarnings({"rawtypes"}) boolean failure = results.get("failure") != null && ((SimpleOrderedMap)results.get("failure")).size() > 0; + if(isPrs) { + TimeOut timeout = new TimeOut(Integer.getInteger("solr.waitToSeeReplicasInStateTimeoutSeconds", 120), TimeUnit.SECONDS, timeSource); // could be a big cluster + PerReplicaStates prs = PerReplicaStates.fetch(collectionPath, ocmh.zkStateReader.getZkClient(), null); + while (!timeout.hasTimedOut()) { + if(prs.allActive()) break; + Thread.sleep(100); + prs = PerReplicaStates.fetch(collectionPath, ocmh.zkStateReader.getZkClient(), null); + } + if (prs.allActive()) { + // we have successfully found all replicas to be ACTIVE + // Now ask Overseer to fetch the latest state of collection + // from ZK + ocmh.overseer.submit(new RefreshCollectionMessage(collectionName)); + } else { + failure = true; + } + } if (failure) { // Let's cleanup as we hit an exception // We shouldn't be passing 'results' here for the cleanup as the response would then contain 'success' Review comment: This is resolved now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org