donnerpeter commented on a change in pull request #2332:
URL: https://github.com/apache/lucene-solr/pull/2332#discussion_r573531516
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##########
@@ -433,24 +433,26 @@ private boolean canBeBrokenAt(String word, String
breakStr, int breakPos) {
Set<String> result = new LinkedHashSet<>();
for (String candidate : suggestions) {
- result.add(adjustSuggestionCase(candidate, wordCase));
+ result.add(adjustSuggestionCase(candidate, wordCase, word));
if (wordCase == WordCase.UPPER && dictionary.checkSharpS &&
candidate.contains("ß")) {
result.add(candidate);
}
}
return new ArrayList<>(result);
}
- private String adjustSuggestionCase(String candidate, WordCase original) {
- if (original == WordCase.UPPER) {
+ private String adjustSuggestionCase(String candidate, WordCase originalCase,
String original) {
+ if (originalCase == WordCase.UPPER) {
String upper = candidate.toUpperCase(Locale.ROOT);
if (upper.contains(" ") || spell(upper)) {
return upper;
}
}
- if (original == WordCase.UPPER || original == WordCase.TITLE) {
- String title = dictionary.toTitleCase(candidate);
- return spell(title) ? title : candidate;
+ if (Character.isUpperCase(original.charAt(0))) {
+ String title = Character.toUpperCase(candidate.charAt(0)) +
candidate.substring(1);
+ if (title.contains(" ") || spell(title)) {
Review comment:
In this place, the plain normal space is hardcoded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
