[ 
https://issues.apache.org/jira/browse/SOLR-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281133#comment-17281133
 ] 

ASF subversion and git services commented on SOLR-15118:
--------------------------------------------------------

Commit e89fba6fe7739cb213560b94b6a4a76e40c2e4a5 in lucene-solr's branch 
refs/heads/master from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e89fba6 ]

SOLR-15118: Convert /v2/collections APIs to annotations (#2281)

Solr supports two different ways to write v2 APIs: a JSON spec based
approach, and one based on annotated POJOs.  The POJO method is now
preferred.

This commit switches the /v2/collections APIs over to the
annotation-based approach.  Since V2RequestSupport only works with
jsonspec-based APIs, this commit also changes CollectionAdminRequest
to no longer implement that interface.

> Make /v2/collections APIs annotation-based
> ------------------------------------------
>
>                 Key: SOLR-15118
>                 URL: https://issues.apache.org/jira/browse/SOLR-15118
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: v2 API
>    Affects Versions: master (9.0)
>            Reporter: Jason Gerlowski
>            Assignee: Jason Gerlowski
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> The {{ApiBag}} class used to register v2 APIs (and the {{PathTrie}} object 
> underlying it) only holds a single {{Api}} object for a given "method" and 
> "path" combination.  In short this means that API commands with the same 
> method and path must be declared homogenously: they either have to all be in 
> the JSON spec, or all be in annotated Java classes.
> The SIP-12 proposal calls for new "list-backups" and "delete-backups" APIs.  
> For these v2 APIs to be annotation-based, as is preferred going forward, all 
> of the existing /v2/collections APIs must be changed to be annotation-based 
> as well.
> It's worth noting that this will cause the introspection output to lose the 
> "description" text for these APIs and their parameters, as there's no support 
> for this yet for annotation-based v2 APIs.  See SOLR-15117 for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to