jaisonbi commented on pull request #2213:
URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-772993254
Thanks for the detailed suggestion. @bruno-roustant
Will add a **new custom codec** to support compression or un-compression
mode. I name it as "Lucene90ExpertCodec", in this codec, user will have more
compression choices, likes Terms Dict compression, Binary DocValue compression..
One doubt, PerFieldDocValuesFormat provides one method for getting Format
according to field name.
`public abstract DocValuesFormat getDocValuesFormatForField(String field);`
so we need to use the approach as @bruno-roustant suggested:
> The choice can be made either based on a config (e.g. file) which lists
all compressed DocValue based fields, or based on a naming convention.
we need to maintain the config file, and the field name list may got
change...Regarding on the "naming convention" approach, we need to give rules
to the field name definition(Please correct me if I am wrong)...I am afraid
it's not simple enough:)
There will be 2 options:
1. Use a global switch in "Lucene90ExpertCodec", so Terms-Dict
compression/Binary DocValue Compression can be enabled easily.
2. Based on PerFieldDocValuesFormat, but add one more method:
`public abstract DocValuesFormat getDocValuesFormatForField(FieldInfo
field);`
We can add new attribute in FieldInfo to identify the
compression-enabled fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
