gerlowskija opened a new pull request #2281: URL: https://github.com/apache/lucene-solr/pull/2281
# Description Solr supports two different ways to write v2 APIs: a JSON spec based approach, and one based on annotated POJOs. The POJO method is now preferred. This commit switches the /v2/collections APIs over to the annotation-based approach. # Solution This commit introduces a relatively rote migration of the JSON spec over to annotated POJOs. There's little of note here, except for cases where the v2 JSON spec was missing support for params supported by the v1 APIs. Here I had to make a few decisions as to whether property names should be retained, etc. A good example of this is the v2 backup API, which had several params not covered by the existing v2 spec. # Tests Adds a new test: `V2CollectionsAPIMappingTest.java` to test the v2->v1 conversion. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
