dsmiley commented on a change in pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#discussion_r567811574
##########
File path: solr/core/src/resources/ImplicitPlugins.json
##########
@@ -66,29 +66,13 @@
"class": "solr.LukeRequestHandler",
"useParams":"_ADMIN_LUKE"
},
- "/admin/system": {
Review comment:
I think we can't get away with this; the admin UI uses it and perhaps
other parts of Solr? Did you try bringing up Solr with this change and using
the admin UI to click on specific cores?
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
##########
@@ -149,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add( "security", getSecurityInfo(req) );
rsp.add( "system", getSystemInfo() );
if (solrCloudMode) {
- rsp.add("node", getCoreContainer(req,
core).getZkController().getNodeName());
+ rsp.add(PARAM_NODE, getCoreContainer(req,
core).getZkController().getNodeName());
Review comment:
PARAM_NODE is called that because it's a _parameter_. It's use here in
a response structure is dubious because it's not a parameter. Other keys of
the response above just use static strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
