mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-770069329


   Thanks @cammiemw!
   
   One thing I noticed after I pushed was the new `Scorable.smothingScore(int 
docId)` method: why does this take the `int docId` parameter?  Shouldn't it 
take no parameters, like `score()`, and always return smoothing score for the 
"current" `docId` instead?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to