dweiss commented on a change in pull request #2249:
URL: https://github.com/apache/lucene-solr/pull/2249#discussion_r565650241



##########
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##########
@@ -67,6 +75,14 @@ public boolean spell(String word) {
     return false;
   }
 
+  private boolean removeTrailingDots(String word) {

Review comment:
       Should it be called spellWithTrailingDots() or something? Right now it 
reads as if it had side effects... Maybe I'm paranoid though. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to