[
https://issues.apache.org/jira/browse/SOLR-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273037#comment-17273037
]
ASF subversion and git services commented on SOLR-15001:
--------------------------------------------------------
Commit 70c21f066efca4239ef64ddefa52438e2caad6d0 in lucene-solr's branch
refs/heads/reference_impl_dev from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=70c21f0 ]
SOLR-15001 Docker: require init_var_solr.sh (#2083)
The Dockerfile should not initialize /var/solr's contents because this is
confusing and redundant with init_var_solr.sh.
No need for init_var_solr.sh to echo what it does; VERBOSE can be used to
accomplish that.
Separate CHANGES.md for Docker and contrib modules.
> Docker: require init_var_solr.sh; don't init in Dockerfile
> ----------------------------------------------------------
>
> Key: SOLR-15001
> URL: https://issues.apache.org/jira/browse/SOLR-15001
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Docker
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I propose removing initialization of /var/solr from the Dockerfile, thus
> leaving only init_var_solr to do this. The fact that it's in two places means
> that the image has two solr.xml, two zoo.cfg, two log4j2.xml. This
> initialization itself must be maintained twice. That leads to confusion (it
> did with my colleagues and I) about which copy is going to be used. Imagine
> you are basing your company Solr Dockerfile on top of this one (i.e. official
> is the FROM) and need to do modifications. Do you modify
> /opt/solr/server/solr/solr.xml? Surprise surprise, sometimes it is copied to
> /var/solr/data/ by the init_var_solr script but _sometimes_ it isn't because
> the Dockerfile here will do it, thus ignoring the customizations made to
> solr.xml in the next image layer.
> After making this change, our wonderful tests exposed that solr-demo wasn't
> invoking init_var_solr.
> THIS ISSUE IS COPIED FROM https://github.com/docker-solr/docker-solr/pull/354
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
