timatbw commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r560811466
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -71,6 +71,7 @@
protected final String coreName;
private final SolrRequestParsers _parser;
private final RequestWriterSupplier supplier;
+ private boolean containerIsLocal = false;
Review comment:
That would be good, but there's no context available to create a cc
because the original parameters (e.g. NodeConfig or solrHome Path) aren't in
scope then.
I'm not that worried about this boolean flag because it's private to the
class so we know where it's set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
