uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761802566
Hi, I added a small refactoring of the method `useDirectIO(...)` that can be overridden by subclasses (currently the test uses this to enforce usage of directIO). The protected method now gets filename, IOContext and the file size (as OptionalLong, as it is unknown when writing a file). The default implementation does what @mikemccand implemented back in 2012. I also added a test to ensure several merge contexts and file sizes introduce the correct behaviour. What do other think, should I merge this to master now? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
