danmuzi commented on a change in pull request #2200: URL: https://github.com/apache/lucene-solr/pull/2200#discussion_r556740515
########## File path: lucene/core/src/test/org/apache/lucene/index/TestTermsEnumDeadlock.java ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.index; + +import org.apache.lucene.util.BytesRef; +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; +import java.lang.management.ManagementFactory; +import java.lang.management.RuntimeMXBean; +import java.nio.file.Paths; +import java.util.concurrent.ThreadLocalRandom; +import java.util.concurrent.TimeUnit; + +public class TestTermsEnumDeadlock extends Assert { + private static final int MAX_TIME_SECONDS = 15; + + @Test + public void testDeadlock() throws Exception { + for (int i = 0; i < 20; i++) { + // Fork a separate JVM to reinitialize classes. Review comment: Thank you for your review @uschindler :D It was added to ensure working. But I agree with your comment about test iteration. So I'll delete the for-loop statement and change it to run only once. As for the necessity of deadlock test, I'll add TODO comment. Later, if someone applies to static checker about it, I'll delete it at that time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
