[ 
https://issues.apache.org/jira/browse/SOLR-14924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257217#comment-17257217
 ] 

David Smiley commented on SOLR-14924:
-------------------------------------

There are test failures in TestReplicationHandler introduced by this change (I 
think).  See 
https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-Tests-8.x/1255/
{preformat}
java.lang.ClassCastException: java.lang.Integer cannot be cast to 
java.lang.String
        at 
__randomizedtesting.SeedInfo.seed([754427253A1E4E95:F190450AC46671D]:0)
        at 
org.apache.solr.handler.TestReplicationHandler.doTestDetails(TestReplicationHandler.java:361)
{preformat}
The test could be made to convert to a string.  But it suggests an 
inconsistency that ought to be fixed -- apparently ReplicationHandler sometimes 
returns its details using all strings and othertimes with the typed variants -- 
and that's bad.

> Some ReplicationHandler metrics are reported using incorrect types
> ------------------------------------------------------------------
>
>                 Key: SOLR-14924
>                 URL: https://issues.apache.org/jira/browse/SOLR-14924
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 8.6.3, 8.7
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Major
>             Fix For: 8.7
>
>         Attachments: SOLR-14924.patch
>
>
> Some metrics reported from {{ReplicationHandler}} use incorrect types - they 
> are reported as String values instead of the numerics.
> This is caused by using {{ReplicationHandler.addVal}} utility method with the 
> type {{Integer.class}}, which the method doesn't support and it returns the 
> value as a string.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to