[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253719#comment-17253719
]
Dawid Weiss commented on LUCENE-9570:
-------------------------------------
Very long string concatenations (and arithmetic expressions) get broken over
several lines.
{code}
if (VERBOSE_DELETES) {
- return "gen=" + gen + " numTerms=" + numTermDeletes + ", deleteTerms=" +
deleteTerms
- + ", deleteQueries=" + deleteQueries + ", fieldUpdates=" + fieldUpdates
- + ", bytesUsed=" + bytesUsed;
+ return "gen="
+ + gen
+ + " numTerms="
+ + numTermDeletes
+ + ", deleteTerms="
+ + deleteTerms
+ + ", deleteQueries="
+ + deleteQueries
+ + ", fieldUpdates="
+ + fieldUpdates
+ + ", bytesUsed="
+ + bytesUsed;
{code}
If it's semantically important, this can be manually grouped using parentheses,
then the formatted code will preserve groups:
{code}
if (VERBOSE_DELETES) {
return ("gen=" + gen)
+ (" numTerms=" + numTermDeletes)
+ (", deleteTerms=" + deleteTerms)
+ (", deleteQueries=" + deleteQueries)
+ (", fieldUpdates=" + fieldUpdates)
+ (", bytesUsed=" + bytesUsed);
{code}
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be relatively quick.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
