murblanc commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r547236069
##########
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##########
@@ -136,8 +154,13 @@ public ZkWriteCommand modifyCollection(final ClusterState
clusterState, ZkNodePr
return ZkStateWriter.NO_OP;
}
- return new ZkWriteCommand(coll.getName(),
- new DocCollection(coll.getName(), coll.getSlicesMap(), m,
coll.getRouter(), coll.getZNodeVersion(), coll.getZNode()));
+ DocCollection collection = new DocCollection(coll.getName(),
coll.getSlicesMap(), m, coll.getRouter(), coll.getZNodeVersion(),
coll.getZNode());
+ if (replicaOps == null){
+ return new ZkWriteCommand(coll.getName(), collection);
+ } else {
+ return new ZkWriteCommand(coll.getName(), collection, replicaOps, true);
+ }
Review comment:
My bad, the two are different.
When `replicaOps` is `null`, `ops` in `ZkWriteCommand` is set to
`PerReplicaStates.WriteOps.touchChildren()`.
When `replicaOps` is not `null`, `ops` in `ZkWriteCommand` is set to
`replicaOps`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
